-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Transform] adds geotile_grid support in group_by #56514
Merged
benwtrent
merged 4 commits into
elastic:master
from
benwtrent:feature/transform-add-geotile_grid-group-by
May 11, 2020
Merged
[Transform] adds geotile_grid support in group_by #56514
benwtrent
merged 4 commits into
elastic:master
from
benwtrent:feature/transform-add-geotile_grid-group-by
May 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/ml-core (:ml/Transform) |
hendrikmuhs
approved these changes
May 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great addition, only added a few nits.
...el/src/main/java/org/elasticsearch/client/transform/transforms/pivot/GeoTileGroupSource.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/elasticsearch/client/transform/transforms/pivot/GeoTileGroupSourceTests.java
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/xpack/core/transform/transforms/pivot/GeoTileGroupSource.java
Outdated
Show resolved
Hide resolved
...n/transform/src/main/java/org/elasticsearch/xpack/transform/transforms/pivot/SchemaUtil.java
Show resolved
Hide resolved
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
May 11, 2020
This adds support for grouping by geo points. This uses the agg [geotile_grid](https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-bucket-geotilegrid-aggregation.html). I am opting to store the tile results of group_by as a `geo_shape` so that users can query the results. Additionally, the shapes could be visualized and filtered in the kibana maps app. relates to elastic#56121
benwtrent
added a commit
that referenced
this pull request
May 11, 2020
This adds support for grouping by geo points. This uses the agg [geotile_grid](https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-bucket-geotilegrid-aggregation.html). I am opting to store the tile results of group_by as a `geo_shape` so that users can query the results. Additionally, the shapes could be visualized and filtered in the kibana maps app. relates to #56121
29 tasks
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 4, 2020
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 5, 2020
github-actions bot
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 5, 2020
github-actions bot
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 5, 2020
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 5, 2020
Relates: elastic/elasticsearch#56514 Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 5, 2020
Relates: elastic/elasticsearch#56514 Co-authored-by: Russ Cam <russ.cam@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for grouping by geo points. This uses the agg geotile_grid.
I am opting to store the tile results of group_by as a
geo_shape
so that users can query the results. Additionally, the shapes could be visualized and filtered in the kibana maps app.relates to #56121